Re: [PATCH] ftrace,arm: add notrace to ARM sched_clock routines - resend

From: Linus Walleij
Date: Sun Jun 14 2009 - 13:51:27 EST


2009/6/13 Tim Bird <tim.bird@xxxxxxxxxxx>:

> Add notrace attribute to sched_clock, to avoid
> recursion with ftrace function tracing.
>
> Signed-off-by: Tim Bird <tim.bird@xxxxxxxxxxx>
> ---
> arch/arm/mach-mmp/time.c | 2 +-
> arch/arm/mach-pxa/time.c | 2 +-
> arch/arm/mach-realview/core.c | 2 +-
> arch/arm/mach-sa1100/generic.c | 2 +-
> arch/arm/mach-versatile/core.c | 2 +-
> arch/arm/plat-omap/common.c | 4 ++--
> 6 files changed, 7 insertions(+), 7 deletions(-)

And now that Paul Mundt is making it possible to use the default
sched_clock() with the generic clocksource and the OMAP hack
will likely go away, should the default implementation in
kernel/sched_clock.c also be tagged as
unsigned long long notrace __attribute__((weak)) sched_clock(void)
or something?

Should it be tagged notrace even if it's the old jiffybased one even?

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/