Re: kallsyms broken on ARM by commit 17b1f0d

From: Mike Frysinger
Date: Mon Jun 15 2009 - 08:52:23 EST


On Mon, Jun 15, 2009 at 08:47, Catalin Marinas wrote:
> With the above commit, kallsyms on ARM no longer show correct
> information. That's a trace with this commit:
>
> Â Â[<c007bfec>] _etext+0xffd9bfec/0x126d8
> Â Â[<c00795e4>] _etext+0xffd995e4/0x126d8
> Â Â[<c0147d94>] _etext+0xffe67d94/0x126d8
> Â Â[<c0147f10>] _etext+0xffe67f10/0x126d8
> Â Â[<c01481bc>] _etext+0xffe681bc/0x126d8
> Â Â[<c0148218>] _etext+0xffe68218/0x126d8
> Â Â[<c0143db0>] _etext+0xffe63db0/0x126d8
> Â Â[<c0143e18>] _etext+0xffe63e18/0x126d8
> Â Â[<c007f250>] _etext+0xffd9f250/0x126d8
> Â Â[<c007c238>] _etext+0xffd9c238/0x126d8
> Â Â[<c007c2b8>] _etext+0xffd9c2b8/0x126d8
> Â Â[<c0023dc0>] _etext+0xffd43dc0/0x126d8
>
> and with the commit reverted:
>
> Â Â[<c007bfec>] kmemleak_alloc+0x14c/0x260
> Â Â[<c00795e4>] kmem_cache_alloc+0xd4/0x108
> Â Â[<c0147d94>] tty_ldisc_try_get+0x18/0xb0
> Â Â[<c0147f10>] tty_ldisc_get+0x18/0x40
> Â Â[<c01481bc>] tty_ldisc_reinit+0x28/0x5c
> Â Â[<c0148218>] tty_ldisc_release+0x28/0x3c
> Â Â[<c0143db0>] tty_release_dev+0x3cc/0x428
> Â Â[<c0143e18>] tty_release+0xc/0x14
> Â Â[<c007f250>] __fput+0x104/0x1c4
> Â Â[<c007c238>] filp_close+0x70/0x7c
> Â Â[<c007c2b8>] sys_close+0x74/0xa8
> Â Â[<c0023dc0>] ret_fast_syscall+0x0/0x28
>
> Any idea what went wrong? I haven't looked at your commit in detail.

try this patch (Gentoo mail server is broken atm, so attaching)
-mike

Attachment: 0001-kallsyms-fix-inverted-valid-symbol-checking.patch
Description: Binary data