Re: linux-next: scsi tree build failure

From: James Bottomley
Date: Mon Jun 15 2009 - 11:12:04 EST


On Mon, 2009-06-15 at 12:17 +1000, Stephen Rothwell wrote:
> Hi James,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> drivers/scsi/ps3rom.c: In function 'ps3rom_interrupt':
> drivers/scsi/ps3rom.c:302: error: implicit declaration of function 'ps3_system_bus_get_drvdata'
> drivers/scsi/ps3rom.c:302: warning: assignment makes pointer from integer without a cast
> drivers/scsi/ps3rom.c: In function 'ps3rom_probe':
> drivers/scsi/ps3rom.c:390: error: implicit declaration of function 'ps3_system_bus_set_drvdata'
> drivers/scsi/ps3rom.c: In function 'ps3rom_remove':
> drivers/scsi/ps3rom.c:421: warning: initialization makes pointer from integer without a cast
>
> Caused by commit 4381bd58427116cd7689831998771ddd58078af9 ("[SCSI]
> ps3rom: Use ps3_system_bus_[gs]et_drvdata() instead of direct access").
> This is number 21 in a series and depends on number 19 which is not yet
> merged. If you instead Ack this patch, Ben will merge it through the
> powerpc tree.
>
> For today, I have used the scsi tree from next-20090612.

OK, dumped the offending patch, so it should be safe to take scsi-misc
again.

I'm so used to merging these type of conversions, I didn't check that it
was using a ps3 specific wrapper instead of a generic device one.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/