Re: iwlwifi: show qos AC parameters

From: Greg KH
Date: Sun Jun 21 2009 - 22:54:29 EST


On Sun, Jun 21, 2009 at 11:07:27AM -0700, Arjan van de Ven wrote:
> On Mon, 15 Jun 2009 21:14:13 GMT
> Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> wrote:
>
> > +static ssize_t show_qos(struct device *d,
> > + struct device_attribute *attr, char
> > *buf) +{
> > + struct iwl_priv *priv = (struct iwl_priv *)d->driver_data;
> > + char *p = buf;
> > + int q;
> > +
> > + for (q = 0; q < AC_NUM; q++) {
> > + p += sprintf(p, "\tcw_min\tcw_max\taifsn\ttxop\n");
> > + p += sprintf(p, "AC[%d]\t%u\t%u\t%u\t%u\n", q,
> > +
>
> wonder what happened to the "one value per file" sysfs rule...

Oh ick.

Thanks Arjan for the pointer.

Who's responsible for this file, and when is it going to be changed?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/