Re: [PATCH v2 1/1] Char: tty, fix tty_port_block_til_ready waiting

From: Jiri Slaby
Date: Wed Jun 24 2009 - 07:43:06 EST


On 06/24/2009 01:30 AM, Andrew Morton wrote:
> On Thu, 18 Jun 2009 09:46:13 +0200
>> --- a/drivers/char/tty_port.c
>> +++ b/drivers/char/tty_port.c
>> @@ -193,7 +193,7 @@ int tty_port_block_til_ready(struct tty_port *port,
>> {
>> int do_clocal = 0, retval;
>> unsigned long flags;
>> - DECLARE_WAITQUEUE(wait, current);
>> + DEFINE_WAIT(wait);
>> int cd;
>>
>> /* block if port is in the process of being closed */
>
> Why is nobody reporting the oopses?

Myaybe because only few drivers use that function. I hit it the first
time I tested cyclades patchset.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/