Re: [PATCH] pata_rdc: driver for RDC ATA devices

[Jeff Garzik]

Alan Cox wrote:
> Try this version instead - forgot to refresh the patch before sending
>
> From: Alan Cox <alan@xxxxxxxxxxxxxxx>
>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> ---
>
>  drivers/ata/Kconfig    |   10 +
>  drivers/ata/Makefile   |    1 
>  drivers/ata/pata_rdc.c |  400 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 411 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/ata/pata_rdc.c

Requesting that linux-ide be CC'd in the future, for this driver...

Seems fine and fairly straightforward to me.  My lone comment -- go 
through and replace magic numbers with named constants, for e.g. the PCI 
config registers that program timings...

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/