Re: [PATCH v3] slow-work: add (module*)work->owner to fix races with module clients

From: David Howells
Date: Fri Jun 26 2009 - 08:52:26 EST


Gregory Haskins <ghaskins@xxxxxxxxxx> wrote:

> The slow_work facility was designed to use reference counting instead of
> barriers for synchronization. The reference counting mechanism is
> implemented as a vtable op (->get_ref, ->put_ref) callback. This is
> problematic for module use of the slow_work facility because it is
> impossible to synchronize against the .text installed in the callbacks:
> There is no way to ensure that the slow-work threads have completely
> exited the .text in question and rmmod may yank it out from under the
> slow_work thread.

This seems reasonable. I'll get round to testing it if I can find the OOM bug
that's nobbling by test machine.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/