Re: [PATCHv3 4/4] kvm: remove in_range from io devices

From: Michael S. Tsirkin
Date: Mon Jun 29 2009 - 08:20:54 EST


On Mon, Jun 29, 2009 at 03:09:19PM +0300, Michael S. Tsirkin wrote:
> This changes bus accesses to use high-level kvm_io_bus_read/kvm_io_bus_write
> functions. in_range now becomes unused so it is removed from device ops in
> favor of read/write callbacks performing range checks internally.
>
> This allows aliasing (mostly for in-kernel virtio), as well as better error
> handling by making it possible to pass errors up to userspace.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

Ugh, forgot this trivial typo fix. Sorry.

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 790bd55..82e76da 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -2276,7 +2276,7 @@ static int vcpu_mmio_read(struct kvm_vcpu *vcpu, gpa_t addr, int len, void *v)
!kvm_iodevice_read(&vcpu->arch.apic->dev, addr, len, v))
return 0;

- return kvm_io_bus_read(vcpu->kvm, &vcpu->kvm->mmio_bus, addr, len, v);
+ return kvm_io_bus_read(&vcpu->kvm->mmio_bus, addr, len, v);
}

static int kvm_read_guest_virt(gva_t addr, void *val, unsigned int bytes,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/