Re: [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bitx86

From: H. Peter Anvin
Date: Mon Jun 29 2009 - 21:20:14 EST


Yinghai Lu wrote:
>>>
>> That doesn't quite look right; for one thing it doesn't handle the
>> (admittedly somewhat unlikely) case of end pointing to the end of the
>> address space.
>>
>> Something like:
>>
>> if (start > (resource_size_t)end-1)
>> continue;
>>

> + if (start > (resource_size_t)end)
> continue;

Erk... thinko on my part. Should have been (resource_size_t)-1.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/