Re: [PATCH v1 6/6][ARM] new ARM SoC support: BCMRing

From: Jean-Christophe PLAGNIOL-VILLARD
Date: Tue Jun 30 2009 - 14:49:41 EST


On 16:30 Fri 26 Jun , Leo (Hao) Chen wrote:
> Hi,
>
> The last patch. This big patch includes the minimal set of our CSP (chip support package), which is our OS independent chip supporting code and headers. All the codes are under arch/arm/mach-bcmring directory.
This patch is unreadable
you need
1) Respect the Linux coding Style
2) to split in small changeset
3) use the kernel API such as clocksource, clock, dmaengine etc...

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/