Re: [PATCH 2/2] Add a driver for the Winbond WPCD376I IRfunctionality.

[Jesse Barnes]

On Wed, 1 Jul 2009 23:47:53 +0200
David HÃrdeman <david@xxxxxxxxxxx> wrote:

> This patch adds a driver for the the Consumer IR (CIR) functionality
> of the Winbond WPCD376I chipset (found on e.g. Intel DG45FC
> motherboards).
> 
> Changes since the driver was first posted to the list:
> o Homebrew dprintk -> dev_dbg
> o Some magic values changed to defines
> o Fixed a bug where the wake-ir-command mask/value would not be
>    written properly
> o Fixed the use of the invert parameter both for wake and normal
>    IR reception.
> 
> Changes since the second post to the list (AKPM's remarks):
> o Various comments added
> o Removed some casts
> o use bitrev8
> o convert data->irdata to unsigned longs, use __set_bit and test_bit
> 
> Andrew, please replace the patch you currently have in the -mm tree
> with this one.
> 
> Signed-off-by: David HÃrdeman <david@xxxxxxxxxxx>

Looking nice to me...  Thanks for writing this, David.

Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/