Re: [PATCH 1/2 v2] dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller

[Dan Williams]

On Wed, Jul 1, 2009 at 6:58 AM, Nicolas Ferre<nicolas.ferre@xxxxxxxxx> wrote:
> Hi,
>
> Just one question Dan (see below).
>
> Nicolas Ferre :
>> This AHB DMA Controller (aka HDMA or DMAC on AT91 systems) is availlable on
>> at91sam9rl chip. It will be used on other products in the future.
>
> [..]
>> +     /*
>> +      * The API requires that no submissions are done from a
>> +      * callback, so we don't need to drop the lock here
>> +      */
>> +     if (callback)
>> +             callback(param);
>
> Even if our dma controller does not seems to take advantage of
> dependency requests...
>
> ...should I add the
> dma_run_dependencies(txd);
> call here to improve conformance to dmaengine standards ?

That would be nice but it is not a strict requirement.

To me it just seems like leaving something for some future developer
to trip over when debugging why channel switching does not work with
this driver.  If you can guarantee that this driver will always be the
only dma_device driver in the system and that future products will not
add additional operation types then maybe it can be omitted.
Otherwise, the overhead of including the call should be negligible.

Regards,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/