Re: [lm-sensors] [PATCH] adxl345 accelerometer hwmon driver

From: Mike Frysinger
Date: Thu Jul 02 2009 - 14:16:05 EST


On Thu, Jul 2, 2009 at 14:12, Hennerich, Michael wrote:
>From: J.I. Cameron [mailto:jic23@xxxxxxxxxxxxxxxx] On Behalf Of
>> Looks like a nice driver, see what you mean about the i2c fun and games
>> you are having though.
>> I'm particularly interested in your use of the fifo:
>>
>>I've only had a quick look, but assuming I read it right, you are using
>>the fifo
>>with a watermark of 0 then spitting out 3 separate events for every
>>element in it.
>>Basically a data ready response unless you fail to read in time. Seems
>>like a sensible
>>approach with this particular chip in input type applications.
>
> We fully use the FIFO - the link Mike sent around was the initial
> checkin.
> After that I fixes some bugs and added functionality.
> BTW I also implemented the Watermark feature.

nah, that link i posted is everything. the kernel.org repo has
cleaned up / squashed changes. so all the little pieces in our
personal repo have been put together to form the one changeset on
kernel.org.

ive been emptying my other subsystem queues and havent gotten around
to input/hwmon/fb yet. i'll start up a thread on our list to see what
people are happy with submitting.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/