Re: PROPOSAL: extend pipe() to support NULL argument.

[Amerigo Wang]

On Fri, Jul 03, 2009 at 05:59:10PM +0800, Changli Gao wrote:
>On Fri, Jul 3, 2009 at 5:42 PM, Amerigo Wang<xiyou.wangcong@xxxxxxxxx> wrote:
>>>I said: It just a special case. Fixing sendfile() won't fix everything.
>>
>> What do you want? Just saving an fd, isn't it?
>>
>> sendfile() does this but you said it's buggy, if you fix it, what is the
>> rest problem?
>>
>You should know why Linux invented splice(2). Not all of the problems
>can be solved by sendfile(2).

Sure, it definitely can be seen from the interface....

>
>>>
>>>In fact, sendfile(2) is implemented via splice(2) infrastructure. The
>>>logic is the same, and much clever than yours. Dive into its code, you
>>>will find the reason why it must be blocked on outfd.
>>
>>
>> Sure, this is done in user-space, definitely....
>>
>Did you review the code of sendfile(2)? 

Not at all.

I just wanted to show what I wanted to say, not to re-implement
sendfile(2).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/