Re: [PATCH 4/5] add isolate pages vmstat

From: KOSAKI Motohiro
Date: Mon Jul 06 2009 - 05:28:23 EST


> > ? ? ? ?printk("Active_anon:%lu active_file:%lu inactive_anon:%lu\n"
> > - ? ? ? ? ? ? ? " inactive_file:%lu"
> > - ? ? ? ? ? ? ? " unevictable:%lu"
> > + ? ? ? ? ? ? ? " inactive_file:%lu unevictable:%lu isolated:%lu\n"
>
> It's good.
> I have a one suggestion.
>
> I know this patch came from David's OOM problem a few days ago.
>
> I think total pages isolated of all lru doesn't help us much.
> It just represents why [in]active[anon/file] is zero.
>
> How about adding isolate page number per each lru ?
>
> IsolatedPages(file)
> IsolatedPages(anon)
>
> It can help knowing exact number of each lru.

Good suggestion!
Will fix.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/