Re: [PATCH] elfcore.h : Fix UML build breakage

[Amerigo Wang]

On Tue, Jul 07, 2009 at 10:41:50PM -0400, Parag Warudkar wrote:
>Commit a65e7bfcd74e4c0939f235d2bf9f48ddb3a57991 breaks UML build with 
>below error - 
>
>In file included from fs/proc/kcore.c:17:
>include/linux/elfcore.h: In function âelf_core_copy_task_regsâ:
>include/linux/elfcore.h:129: error: implicit declaration of function 
>âtask_pt_regsâ
>
>Fix this by restoring the previous behavior of returning 0 for all arches 
>like UML that don't define task_pt_regs.

Good catch!

>
>Signed-off-by: Parag Warudkar <parag.lkml@xxxxxxxxx>
>
>diff --git a/include/linux/elfcore.h b/include/linux/elfcore.h
>index 03ec167..28f722e 100644
>--- a/include/linux/elfcore.h
>+++ b/include/linux/elfcore.h
>@@ -125,7 +125,7 @@ static inline int elf_core_copy_task_regs(struct task_struct *t, elf_gregset_t*
> #ifdef ELF_CORE_COPY_TASK_REGS
> 	
> 	return ELF_CORE_COPY_TASK_REGS(t, elfregs);
>-#else
>+#elif defined task_pt_regs
> 	elf_core_copy_regs(elfregs, task_pt_regs(t));
> #endif
> 	return 0;

#elif defined doesn't match #ifdef well, how about:

#if defined (ELF_CORE_COPY_TASK_REGS)
...
#elif defined (task_pt_regs)
...
#endif

?

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/