Re: [PATCH 0/3] Fix sysrq caused USB performance regressions andleak

[Anders Larsen]

On 2009-07-10 02:01:37, Alan Cox wrote:
> > shouldn't it be
> > +	if (likely(!port->console || !port->sysrq))
> > respectively
> > +	if (unlikely(port->console && port->sysrq)) {
> > 
> > at least for clarity?
> 
> It'll get predicted by the CPU just fine I suspect.

I thought likely() / unlikely() were for the _compiler_ to arrange the
blocks more efficiently?

Anders

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/