[PATCH] x86: Remove spurious printk level from segfault message

From: Roland Dreier
Date: Sat Jul 11 2009 - 03:16:29 EST


Since commit 5fd29d6c ("printk: clean up handling of log-levels and
newlines"), the kernel logs segfaults like:

<6>gnome-power-man[24509]: segfault at 20 ip 00007f9d4950465a sp 00007fffbb50fc70 error 4 in libgobject-2.0.so.0.2103.0[7f9d494f7000+45000]

with the extra "<6>" being KERN_INFO. This happens because the printk
in show_signal_msg() started with KERN_CONT and then used "%s" to pass
in the real level; and KERN_CONT is no longer an empty string, and
printk only pays attention to the level at the very beginning of the
format string.

Therefore, remove the KERN_CONT from this printk, since it is now
actively causing problems (and never really made any sense).

Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxxxxx>
---
arch/x86/mm/fault.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index 85307cc..bfae139 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -697,7 +697,7 @@ show_signal_msg(struct pt_regs *regs, unsigned long error_code,
if (!printk_ratelimit())
return;

- printk(KERN_CONT "%s%s[%d]: segfault at %lx ip %p sp %p error %lx",
+ printk("%s%s[%d]: segfault at %lx ip %p sp %p error %lx",
task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG,
tsk->comm, task_pid_nr(tsk), address,
(void *)regs->ip, (void *)regs->sp, error_code);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/