Re: [PATCH] move sb1250-mac's probe function to .devinit.text

[Maciej W. Rozycki]

On Sat, 11 Jul 2009, Uwe Kleine-K?nig wrote:

> A pointer to sbmac_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
> 
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: Weiwei Wang <weiwei.wang@xxxxxxxxxxxxx>
> Cc: Jeff Garzik <jgarzik@xxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: Stephen Hemminger <shemminger@xxxxxxxxxx>
> Cc: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/net/sb1250-mac.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>

 Fine by me, thanks.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/