Re: [PATCH] hw_breakpoint: remove sample code from hw_breakpoint.h

[Li Zefan]

(sorry for the late reply, I didn't see this mail..)

Frederic Weisbecker wrote:
> On Tue, Jul 07, 2009 at 01:40:11PM +0800, Li Zefan wrote:
>> The sample code is a bit out-dated, and there's already a
>> sample in sample/hw_breakpoint/.
> 
> 
> IMHO these bits of comments are useful and don't overlap the role
> of the samples in sample/
> They only stand there as a quick summup.
> 
> No?
> 

The sample here sets a breakpoint on pid_max, which is what the sample
in sample/ does.

And the code here is out-dated (and incomplete). We can fix it, but
whenver someone changes the APIs, he may forget to update the comments.
We know comments never catch up with code.

So I inclined to delete it, and add a link to sample/.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/