Re: iwl: potential deadlock?

[Jiri Slaby]

On 07/13/2009 10:18 PM, reinette chatre wrote:
> On Mon, 2009-07-13 at 12:34 -0700, Jiri Slaby wrote:
>> we found a potential deadlock in iwl code by our tool.
> 
> What tool is this?

It's called stanse[1], we still work on it.

>> iwl_update_tkip_key()
>> -> spin_lock_irqsave(&priv->sta_lock)
>> -> iwl_send_add_sta()
> 
> iwl_send_add_sta() is called here with flags = CMD_ASYNC
> 
> In iwl_send_add_sta() we have:
> 	if (ret || (flags & CMD_ASYNC))
> 		return ret;

Yes, you're right, indeed. Thanks for the explanation.

[1] http://iti.fi.muni.cz/stanse/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/