Re: [PATCH] move orion_nand's probe function to .devinit.text

[Nicolas Pitre]

On Tue, 14 Jul 2009, Uwe Kleine-König wrote:

> Hi Nicolas,
> 
> On Mon, Jul 13, 2009 at 03:37:23PM -0400, Nicolas Pitre wrote:
> > On Sat, 11 Jul 2009, Uwe Kleine-König wrote:
> > 
> > > A pointer to orion_nand_probe is passed to the core via
> > > platform_driver_register and so the function must not disappear when the
> > > .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> > > unbinding and binding a device to the driver via sysfs will result in an
> > > oops as does a device being registered late.
> > > 
> > > An alternative to this patch is using platform_driver_probe instead of
> > > platform_driver_register plus removing the pointer to the probe function
> > > from the struct platform_driver.
> > 
> > For those kind of platform devices I'd prefer the alternative.
> Can I interpret that as your intend to implement and test it?

"Eventually", yes.  This is however a low priority for me.


Nicolas