Re: sound/pci/riptide/riptide.c compiler warning

[Takashi Iwai]

At Wed, 15 Jul 2009 11:57:30 +0530,
Jaswinder Singh Rajput wrote:
> 
> I am getting this compiler warning in linus tree :
> 
>   CC [M]  sound/pci/riptide/riptide.o
> sound/pci/riptide/riptide.c: In function âalsa_card_riptide_initâ:
> sound/pci/riptide/riptide.c:2200: warning: ignoring return value of â__pci_register_driverâ, declared with attribute warn_unused_result
> 
> This fixes the warning in my case, hope this will be helpful :
> 
> diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
> index 235a71e..fd8a552 100644
> --- a/sound/pci/riptide/riptide.c
> +++ b/sound/pci/riptide/riptide.c
> @@ -2197,9 +2197,9 @@ static int __init alsa_card_riptide_init(void)
>  	if (err < 0)
>  		return err;
>  #if defined(SUPPORT_JOYSTICK)
> -	pci_register_driver(&joystick_driver);
> +	err = pci_register_driver(&joystick_driver);
>  #endif
> -	return 0;
> +	return err;

In that case, the formerly registered audio driver should be
unregistered before returning the error from the probe callback.
Could you fix that?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/