Re: HTC: touchscreen driver

[Frank Rowand]

Joe Perches wrote:
> On Mon, 2009-07-13 at 18:29 -0700, Arve HjÃnnevÃg wrote:
>> On Mon, Jul 13, 2009 at 3:07 PM, Pavel Machek<pavel@xxxxxx> wrote:
>>> -                       printk(KERN_ERR "synaptics_ts_work_func: i2c_transfer failed\n");
>>> +                       printk(KERN_ERR "ts_work: i2c_transfer failed\n");
>> This will make it harder to read the kernel logs since the driver is 
>> no longer specified.
> 
> How about converting to:
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ":%s: " fmt, __func__
> or
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> and pr_<level>()

dev_printk() and the related helpers in include/linux/device.h
might also be useful.

-Frank Rowand
---
Sony Corporation of America

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/