Re: [PATCH 1/2] vga: implements VGA arbitration on Linux

[Dave Airlie]

On Wed, Jul 15, 2009 at 2:15 AM, Greg KH<greg@xxxxxxxxx> wrote:
> Minor comment:
>
>> +#ifdef DEBUG
>> +     printk(KERN_DEBUG "%s\n", __func__);
>> +#endif
>
> You should just use 'dev_dbg() for any debugging statments like this.
> You can turn them on and off dynamically, and you get all of the proper
> device information as to what is going on automatically.
>
> Plus, there's no need for a #ifdef in the code, which is generally
> frowned apon in .c files.
>

We don't have a device in this case, vga arb is more of an abstraction than
an actual device.

I suppose if we were feeling crazy we could add a platform device for it.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/