Re: [PATCH 1/3] Rename pgmoved variable in shrink_active_list()

From: Minchan Kim
Date: Thu Jul 16 2009 - 00:01:45 EST


On Thu, Jul 16, 2009 at 12:16 PM, Andrew
Morton<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 16 Jul 2009 09:52:34 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
>
>> Â Â Â if (file)
>> - Â Â Â Â Â Â __mod_zone_page_state(zone, NR_ACTIVE_FILE, -pgmoved);
>> + Â Â Â Â Â Â __mod_zone_page_state(zone, NR_ACTIVE_FILE, -nr_taken);
>> Â Â Â else
>> - Â Â Â Â Â Â __mod_zone_page_state(zone, NR_ACTIVE_ANON, -pgmoved);
>> + Â Â Â Â Â Â __mod_zone_page_state(zone, NR_ACTIVE_ANON, -nr_taken);
>
> we could have used __sub_zone_page_state() there.

Yes. It can be changed all at once by separate patches. :)



--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/