Re: [PATCH 1/3] Rename pgmoved variable in shrink_active_list()

From: Andrew Morton
Date: Thu Jul 16 2009 - 00:49:51 EST


On Thu, 16 Jul 2009 13:38:21 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:

> > On Thu, 16 Jul 2009 13:22:30 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
> >
> > > -#define __add_zone_page_state(__z, __i, __d) \
> > > - __mod_zone_page_state(__z, __i, __d)
> > > -#define __sub_zone_page_state(__z, __i, __d) \
> > > - __mod_zone_page_state(__z, __i,-(__d))
> > > -
> >
> > yeah, whatever, I don't think they add a lot of value personally.
> >
> > I guess they're a _bit_ clearer than doing __sub_zone_page_state() with
> > a negated argument. Shrug.
>
> OK, I've catched your point.

I don't think I have a point ;)

> I'll make all caller replacing patches.

Well, if you guys think it's worth it, sure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/