Re: [PATCH 1/2] tracing/function: fix the return value of ftrace_trace_onoff_callback()

From: Li Zefan
Date: Thu Jul 16 2009 - 05:31:14 EST


>> ftrace_trace_onoff_callback() will return error even if we do the
>> right operation, for example:
>>
>> # echo _spin_*:traceon:10 > set_ftrace_filter
>> -bash: echo: write error: Invalid argument
>> # cat set_ftrace_filter
>> #### all functions enabled ####
>> _spin_trylock_bh:traceon:count=10
>> _spin_unlock_irq:traceon:count=10
>> _spin_unlock_bh:traceon:count=10
>> _spin_lock_irq:traceon:count=10
>> _spin_unlock:traceon:count=10
>> _spin_trylock:traceon:count=10
>> _spin_unlock_irqrestore:traceon:count=10
>> _spin_lock_irqsave:traceon:count=10
>> _spin_lock_bh:traceon:count=10
>> _spin_lock:traceon:count=10
>>
>> We want to set _spin_*:traceon:10 to set_ftrace_filter, it complain
>> with "Invalid argument", but the operation is successful.
>> So, this patch fix it.
>>
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
>
> Looks good, thanks.
>
> Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>

Reviewed-by: Li Zefan <lizf@xxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/