Re: [PATCH -tip -v12 01/11] x86: instruction decoder API

From: Sam Ravnborg
Date: Thu Jul 16 2009 - 12:37:19 EST


>
> diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
> new file mode 100644
> index 0000000..01e079a
> --- /dev/null
> +++ b/arch/x86/include/asm/inat.h
> @@ -0,0 +1,125 @@
> +#ifndef _ASM_INAT_INAT_H
> +#define _ASM_INAT_INAT_H

[With reference to comment on patch 2/12...]
You create inat.h here.
Could you investigave what is needed to factor out the stuff
needed from userspace so we can avoid the ugly havk where
you redefine types.h?

Maybe create a inat_types.h + inat.h as we do in other cases?

Same for the other files that requred the types.h hack.

Sam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/