Re: [PATCH -tip -v12 02/11] x86: x86 instruction decoder build-timeselftest

[Masami Hiramatsu]

Sam Ravnborg wrote:
>>>> +      cmd_posttest = objdump -d $(objtree)/vmlinux | awk -f $(srctree)/arch/x86/scripts/distill.awk | $(obj)/test_get_len
>>>> +
>>> You are using the native objdump here.
>>> But I assume this fails miserably when you build x86 on a powerpc host.
>>> In other words - you broke an allyesconfig build for -next...
>>> We have $(OBJDUMP) for this.
>> Ah, I see... Would you know actual name of x86-objdump on the powerpc
>> (or any other crosscompiling host)? I just set "OBJDUMP=objdump" is OK?
>> I'm not so sure about cross-compiling kernel...
> 
> Replacing objdump with $(OBJDUMP) will do the trick.
> We set OBJDUMP to the correct value in the top-level makefile.
> 
> Are there any parts of your user-space program that rely
> on the host is little-endian?
> If it does then it would fail on a power-pc target despite using the
> correct objdump.

Hmm, as far as I can see, the result of get_next() macro with the types
more than two bytes(s16, s32...) might be effected.
But it doesn't effect get_insn_len test because those values are ignored.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/