Re: [PATCH 1/4] drivers/block: adjust NULL test

[Tejun Heo]

Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
> 
> dtp is derefenced on the lines above the test !dtp, and so it cannot be
> NULL at this point.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @r@
> expression x,E,E1;
> identifier f,l;
> position p1,p2;
> @@
> 
> *x@p1->f = E1;
> ... when != x = E
>     when != goto l;
> (
> *x@p2 == NULL
> |
> *x@p2 != NULL
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@xxxxxxx>

Indeed, added to my temp block tree.  Will forward upstream in a few
days.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/