Re: [PATCH] Delete redundant IRQ_DISABLED check in irq_thread

From: Thomas Gleixner
Date: Sat Jul 18 2009 - 05:42:53 EST


On Sat, 18 Jul 2009, Barry Song wrote:
> I guess people call disable_irq to disable the whole execution,
> specially to disable the hardirq(then both top and bottom are
> blocked). It's really strange the disable operation only blocks the
> bottom-half.

The disable blocks both. After the disable no hardirq comes in
anymore.

The disabled check in the thread is just to take care of the case when
the disable comes in between the hardirq and the thread handler.

That way we avoid doing the full tracking of the hardirq / thread
chain simply because it is complex and would produce significant
overhead in the fast path for no gain. It could be done, but it's not
worth the trouble.

Thanks,

tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/