potential null dereference in sysfs_override_clocksource()

From: Dan Carpenter
Date: Sun Jul 19 2009 - 10:03:06 EST


Hello,

I am testing a source checker (http://repo.or.cz/w/smatch.git).

It found an issue in sysfs_override_clocksource() from
kernel/time/clocksource.c. If "len" is zero then "ovr" is null and
checking ovr->flags will oops on line 517.

kernel/time/clocksource.c
516 if (tick_oneshot_mode_active() &&
517 !(ovr->flags & CLOCK_SOURCE_VALID_FOR_HRES)) {
518 printk(KERN_WARNING "%s clocksource is not HRT compatible. "

regards,
dan carpenter



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/