Re: [PATCH 3/10] drivers/hid: Move dereferences below a NULL test

[Jiri Kosina]

On Sun, 19 Jul 2009, Julia Lawall wrote:

> From: Julia Lawall <julia@xxxxxxx>
> 
> If the NULL test is necessary, then the dereferences should be moved below
> the NULL test.
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @@
> type T;
> expression E,E1;
> identifier i,fld;
> statement S;
> @@
> 
> - T i = E->fld;
> + T i;
>   ... when != E=E1
>       when != i
>   if (E == NULL||...) S
> + i = E->fld;
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@xxxxxxx>

Good catch, applied, thanks Julia.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/