Re: [PATCH] SOUND: OSS sequencer should be initialized aftersnd_seq_system_client_init

From: Catalin Marinas
Date: Sun Jul 19 2009 - 18:21:14 EST


On Sun, 2009-07-19 at 21:58 +0530, Jaswinder Singh Rajput wrote:
> [PATCH] SOUND: OSS sequencer should be initialized after snd_seq_system_client_init
>
> When build SND_SEQUENCER in kernel then OSS sequencer(alsa_seq_oss_init)
> is initialized before System (snd_seq_system_client_init) which leads to
> memory leak :

Thanks for investigating this. I haven't looked at the code in detail
but I find it a bit weird that initialisation order fixes the memory
leak. Shouldn't the memory allocation logic change slightly to avoid the
leak as well (that's in case someone manually inserts the modules in the
wrong order)?

--
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/