Re: [patch 00/54] [Announce] Microsoft Hyper-V drivers for Linux

From: Greg KH
Date: Mon Jul 20 2009 - 13:48:12 EST


On Mon, Jul 20, 2009 at 01:15:23PM -0400, Dave Jones wrote:
> On Mon, Jul 20, 2009 at 07:09:11PM +0200, Matthias Urlichs wrote:
> > Hi,
> >
> > Dave Jones:
> > > Given the numerous cleanup patches that already exist, is there any reason
> > > to not just post the cleaned up drivers ? It would certainly be more
> > > reviewable than the current pile.
> > >
> > Feel free to apply / combinediff these patches before reviewing. :-P
> >
> > Personally, I don't want to ever see another patch where substantial
> > changes (for some nontrivial value of "substantial") are intermixed
> > with distracting s/\<BOOLEAN\>/bool/g cleanups.
>
> 'Substantial changes' doesn't matter when it's an initial submission.
> By its nature, it's a substantial change.

Note, to keep the proper authorship information, for a lot of drivers in
the staging tree, we commit the original driver with the correct Author:
and signed-off-by lines, and then we do cleanups after that to properly
attribute the developers doing that work.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/