Re: [PATCH] move macsonic's probe function to .devinit.text

[Uwe Kleine-König]

Hi Finn,

On Wed, Jul 22, 2009 at 01:14:36AM +1000, Finn Thain wrote:
> On Sat, 11 Jul 2009, Uwe Kleine-K?nig wrote:
>
>> A pointer to mac_sonic_probe is passed to the core via  
>> platform_driver_register and so the function must not disappear when 
>> the .init sections are discarded.  Otherwise (if also having HOTPLUG=y) 
>> unbinding and binding a device to the driver via sysfs will result in 
>> an oops as does a device being registered late.
>
> This patch works for me (tested on a Quadra 630). I still get an oops on  
> rmmod, but that's a separate issue. I'll send a patch for that.
Thanks, I'll add a

	Tested-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

to the patch description.

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/