Re: Linux 2.6.27.27

[Krzysztof Oledzki]

On Wed, 22 Jul 2009, Jens Rosenboom wrote:

> On Wed, 2009-07-22 at 10:32 +0200, Krzysztof Oledzki wrote:
> > On Wed, 22 Jul 2009, Krzysztof Oledzki wrote:
> >
> > > On Tue, 21 Jul 2009, Linus Torvalds wrote:
> > >
> > > > On Tue, 21 Jul 2009, Linus Torvalds wrote:
> > > > > Anyway, I bet we can work around the compiler bug by just changing the
> > > > > type of "i" from "unsigned char" to be a plain "int".
> > > >
> > > > IOW, like this.
> > > >
> > > > 		Linus
> > > >
> > > > ---
> > > > drivers/video/fbmon.c |    4 ++--
> > > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
> > > > index 5c1a2c0..af4a15c 100644
> > > > --- a/drivers/video/fbmon.c
> > > > +++ b/drivers/video/fbmon.c
> > > > @@ -256,8 +256,8 @@ static void fix_edid(unsigned char *edid, int fix)
> > > >
> > > > static int edid_checksum(unsigned char *edid)
> > > > {
> > > > -	unsigned char i, csum = 0, all_null = 0;
> > > > -	int err = 0, fix = check_edid(edid);
> > > > +	unsigned csum = 0, all_null = 0;
>
> I guess Linus shouldn't have deleted the "char" here...

Yep! However, it took me one more hour to find it. I should have read my 
mails more often. ;)

Thanks.

Best regards,

			Krzysztof Olędzki