Re: [alsa-devel] [RFC] [PATCH 3/3] ASoC: add support for Amstrad E3 (Delta) machine

[Takashi Iwai]

At Wed, 22 Jul 2009 12:03:28 +0100,
Mark Brown wrote:
> 
> > +	/* Setup pins after corresponding bits if changed */
> > +	if ((bool)snd_soc_dapm_get_pin_status(codec, "Speaker") !=
> > +			(bool)(function & (1 << AMS_DELTA_SPEAKER))) {
> 
> Don't like these casts...  why are they needed?

Because the right side is the bit operation?
The cast doesn't look nice, though...


Takashi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/