Re: [alsa-devel] [RFC] [PATCH 3/3] ASoC: add support for AmstradE3 (Delta) machine

[Janusz Krzysztofik]

Mark Brown wrote:
> On Wed, Jul 22, 2009 at 01:39:22PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
>
> > > > +	/* Setup pins after corresponding bits if changed */
> > > > +	if ((bool)snd_soc_dapm_get_pin_status(codec, "Speaker") !=
> > > > +			(bool)(function & (1 << AMS_DELTA_SPEAKER))) {
>
> > > Don't like these casts...  why are they needed?
>
> > Because the right side is the bit operation?
>
> Ick, yes.
>
> > The cast doesn't look nice, though...
>
> Indeed.  I'd suggest rewriting to try to do less in the if statement - a
> helper function seems to be in order here since the same code is
> repeated several times with different pins and bitmasks.

Thanks, I'll rewrite as you suggest.

Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/