Re: [PATCH 3/6] regulator: Warn when unregistering an in-useregulator

From: Liam Girdwood
Date: Wed Jul 22 2009 - 16:15:26 EST


On Tue, 2009-07-21 at 16:00 +0100, Mark Brown wrote:
> We're probably going to start oopsing fairly soon after this happens.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/regulator/core.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 33a8c3c..e5ccc9f 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -2229,6 +2229,7 @@ void regulator_unregister(struct regulator_dev *rdev)
> return;
>
> mutex_lock(&regulator_list_mutex);
> + WARN_ON(rdev->open_count)

Missing ; Fixed.

> unset_regulator_supplies(rdev);
> list_del(&rdev->list);
> if (rdev->supply)

Applied.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/