Re: [PATCH 6/6] regulator: Provide mode to status conversionfunction

From: Mark Brown
Date: Thu Jul 23 2009 - 04:42:28 EST


On Wed, Jul 22, 2009 at 09:41:28PM +0100, Liam Girdwood wrote:
> On Tue, 2009-07-21 at 16:00 +0100, Mark Brown wrote:

> > +int regulator_mode_to_status(unsigned int);
> > +
> > void *regulator_get_init_drvdata(struct regulator_init_data *reg_init_data);

> I've applied all patches, but I'm wondering whether it would be better
> to eventually merge MODE and STATUS. i.e. have REGULATOR_FAST instead of
> REGULATOR_STATUS_FAST and REGULATOR_MODE_FAST.

I agree, at least lining up the values so you can just assign between
the two would be nice.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/