Re: next: sfi build fails when !CONFIG_ACPI

[Alexander Beregalov]

2009/7/23 Feng Tang <feng.tang@xxxxxxxxx>:
> On Thu, 23 Jul 2009 16:43:30 +0800
> Alexander Beregalov <a.beregalov@xxxxxxxxx> wrote:
>
>> 2009/7/17 Alexander Beregalov <a.beregalov@xxxxxxxxx>:
>> > 2009/7/17 Len Brown <lenb@xxxxxxxxxx>:
>> >>> drivers/sfi/sfi_core.c: In function 'sfi_init':
>> >>> drivers/sfi/sfi_core.c:346: error: 'acpi_disabled' undeclared
>> >>> (first use in this function)
>> >>> drivers/sfi/sfi_core.c:346: error: (Each undeclared identifier is
>> >>> reported only once
>> >>> drivers/sfi/sfi_core.c:346: error: for each function it appears
>> >>> in.)
>> >>>
>> >>>
>> >>> $ grep ACPI .config
>> >>> # Power management and ACPI options
>> >>
>> >> It builds for me.
>> >> Please send me the complete failing .config
>> >
>> > Attached (x86_64)
>>
>> Still fails for me in the same way,
>> X86_64
>> next-20090723
>
> sorry for the late response, please try the following patch:
It obviously works. Thanks

>
> diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c
> index 62e2f98..fa66824 100644
> --- a/drivers/sfi/sfi_core.c
> +++ b/drivers/sfi/sfi_core.c
> @@ -361,9 +361,6 @@ static __init int sfi_find_syst(void)
>
> Âvoid __init sfi_init(void)
> Â{
> - Â Â Â if (!acpi_disabled)
> - Â Â Â Â Â Â Â disable_sfi();
> -
> Â Â Â Âif (sfi_disabled)
> Â Â Â Â Â Â Â Âreturn;
>
> Thanks,
> Feng
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/