Re: [PATCH] hp-wmi: improve rfkill support

From: Frans Pop
Date: Thu Jul 23 2009 - 15:28:27 EST


Alan Jenkins wrote:
> 1) Add support for reading the hardware blocked state. Previously
> we read a combination of the hardware and software blocked states,
> reporting it as the software blocked state. This caused some
> confusing behaviour.
>
> 2) The software state is persistent, mark it as such.
>
> 3) Check rfkill in the resume handler. Both the hard and soft
> blocked states may change over hibernation.

I've added this to my local branch for .31 for my HP 2510p.
Light testing (linux only) showed no problems with .31-rc4.

One question: is it expected that pressing the hardware kill switch only
enables the block for phy0? I guess it's probably sufficient.

$ ./rfkill list # after pressing hardware switch
0: phy0: Wireless LAN
Soft blocked: no
Hard blocked: yes
1: hp-wifi: Wireless LAN
Soft blocked: no
Hard blocked: no
2: hp-bluetooth: Bluetooth
Soft blocked: no
Hard blocked: no

Looks like with bluetooth soft-blocked the wireless leds blink on wifi
network traffic, while with bluetooth unblocked it stays on permanently.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/