Re: [PATCH 1/2] MMC Agressive clocking framework v5

From: Linus Walleij
Date: Thu Jul 23 2009 - 16:25:29 EST


2009/7/23 Adrian Hunter <adrian.hunter@xxxxxxxxx>:

> Have you considered using our enable/disable approach instead?

Didn't see that before, still an ran these patches by Tony... But
yes, I have *indeed* considered that approach and my first patch
was a lot like your, but at the time Pierre said:

> I'm not sure I agree with the design here. What's wrong with using the
> set_ios() callback and the normal clock field?

So I switched to using ios.clock instead, and that's what's been iterated.

That said, *I* am perfectly happy with your patch, so if you send that to
Andrew I will happily drop my patch and adapt the MMCI driver for
your stuff instead if that goes in.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/