Re: [PATCH V2] au1xmmc: dev_pm_ops conversion

From: Dmitry Torokhov
Date: Sat Jul 25 2009 - 15:10:49 EST


On Sat, Jul 25, 2009 at 08:18:58PM +0200, Frans Pop wrote:
> On Saturday 25 July 2009, Dmitry Torokhov wrote:
> > On Wed, Jul 22, 2009 at 05:18:39PM +0200, Manuel Lauss wrote:
> > > Cc: Frans Pop <elendil@xxxxxxxxx>
> > > Signed-off-by: Manuel Lauss <manuel.lauss@xxxxxxxxx>
> > >
> > > +
> > > +static struct dev_pm_ops au1xmmc_pmops = {
> > > + .resume = au1xmmc_resume,
> > > + .suspend = au1xmmc_suspend,
> > > +};
> > > +
> >
> > Was suspend to disk tested? It requires freeze()/thaw().
>
> Is that a regression introduced by this patch then? If so, many more of
> the recent dev_pm_ops conversion patches would need to be revisited.

Yes, as far as I understand they would. Let's ask Rafael to confirm...

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/