Re: [PATCH v2 -tip][RFC] serial8250: update to dev_pm_ops

[Dmitry Torokhov]

On Jul 25, 2009, at 1:59 PM, Erik Ekman <erik@xxxxxxx> wrote:

> serial8250: update to dev_pm_ops
>
> From dmesg:
> Platform driver 'serial8250' needs updating - please use dev_pm_ops
>
> Signed-off-by: Erik Ekman <erik@xxxxxxx>
> --
> Updated to handle hibernation as understood based on info from  
> Rafael J. Wysocki.
> Please let me know if any special handling is needed.
>
> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
> index fb867a9..e93222c 100644
> --- a/drivers/serial/8250.c
> +++ b/drivers/serial/8250.c
> @@ -2982,42 +2982,50 @@ static int __devexit serial8250_remove 
> (struct platform_device *dev)
>    return 0;
> }
>
> -static int serial8250_suspend(struct platform_device *dev,  
> pm_message_t state)
> +static int serial8250_suspend(struct device *dev)
> {
>    int i;
>
>    for (i = 0; i < UART_NR; i++) {
>        struct uart_8250_port *up = &serial8250_ports[i];
>
> -        if (up->port.type != PORT_UNKNOWN && up->port.dev == &dev- 
> >dev)
> +        if (up->port.type != PORT_UNKNOWN && up->port.dev == dev)
>            uart_suspend_port(&serial8250_reg, &up->port);
>    }
>
>    return 0;
> }
>
> -static int serial8250_resume(struct platform_device *dev)
> +static int serial8250_resume(struct device *dev)
> {
>    int i;
>
>    for (i = 0; i < UART_NR; i++) {
>        struct uart_8250_port *up = &serial8250_ports[i];
>
> -        if (up->port.type != PORT_UNKNOWN && up->port.dev == &dev- 
> >dev)
> +        if (up->port.type != PORT_UNKNOWN && up->port.dev == dev)
>            serial8250_resume_port(i);
>    }
>
>    return 0;
> }
>
> +static struct dev_pm_ops serial8250_pm_ops = {
> +    .resume   = serial8250_resume,
> +    .suspend  = serial8250_suspend,
> +    .freeze   = serial8250_resume,
> +    .thaw     = serial8250_suspend,
> +    .restore  = serial8250_resume,
> +    .poweroff = serial8250_suspend,
> +};


Do we really both freeze and poweroff for serial port? I am getting  
wary of these mechanical conversions...

--
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/