Re: [PATCH 13/22] Input: Add support for the WM831x ON pin

[Dmitry Torokhov]

Hi Mark,

On Mon, Jul 27, 2009 at 02:46:03PM +0100, Mark Brown wrote:
> --- /dev/null
> +++ b/drivers/input/misc/wm831x-on.c
> @@ -0,0 +1,163 @@
> +/**
> + * wm831x-on.c - WM831X ON pind river
> + *

"Pind river"? ;)

> +
> +static irqreturn_t wm831x_on_irq(int irq, void *data)
> +{
> +	struct wm831x_on *wm831x_on = data;
> +
> +	schedule_work(&wm831x_on->work.work);

schedule_delayed_work(&wm831x_on->work, 0); - I prefer not to expose
delayed work implementation details.

Other than that:

	Acked-by: Dmitry Torokhov <dtor@xxxxxxx>

Freel free to push this with the rest of the series. If that does not
work out let me know and I will get this driver into my tree.

Thanks!

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/