Re: [PATCH] [x86, msr]: execute on the correct CPU subset

[H. Peter Anvin]

Borislav Petkov wrote:
>  
>  	preempt_disable();
> -	/*
> -	 * FIXME: handle the CPU we're executing on separately for now until
> -	 * smp_call_function_many has been fixed to not skip it.
> -	 */
>  	this_cpu = raw_smp_processor_id();
> -	smp_call_function_single(this_cpu, __rdmsr_on_cpu, &rv, 1);
>  
> -	smp_call_function_many(mask, __rdmsr_on_cpu, &rv, 1);
> +	if (cpumask_test_cpu(this_cpu, mask))
> +		msr_func(&rv);
> +
> +	smp_call_function_many(mask, msr_func, &rv, 1);
>  	preempt_enable();
>  }

Any reason not to use get_cpu() ... put_cpu() instead?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/