Re: [PATCH v2] Remove Spurious PnP Memory Reserved Warning

[David John]

On 07/28/2009 10:01 PM, Jesse Barnes wrote:
> On Tue, 28 Jul 2009 09:36:23 +0530
> David John <davidjon@xxxxxxxxxxx> wrote:
> 
>> Remove unnecessary complaints by the PnP sub-system about memory
>> ranges being reserved.
>>
>> Signed-off-by: David John <davidjon@xxxxxxxxxxx>
>>
>> diff --git a/drivers/pnp/system.c b/drivers/pnp/system.c
>> index 59b9092..84ee297 100644
>> --- a/drivers/pnp/system.c
>> +++ b/drivers/pnp/system.c
>> @@ -48,10 +48,11 @@ static void reserve_range(struct pnp_dev *dev,
>> resource_size_t start,
>>  	 * example do reserve stuff they know about too, so we may
>> well
>>  	 * have double reservations.
>>  	 */
>> -	dev_info(&dev->dev, "%s range 0x%llx-0x%llx %s reserved\n",
>> -		port ? "ioport" : "iomem",
>> -		(unsigned long long) start, (unsigned long long) end,
>> -		res ? "has been" : "could not be");
>> +	if (res) {
>> +		dev_info(&dev->dev, "%s range 0x%llx-0x%llx has been
>> "
>> +			 "reserved\n",	port ? "ioport" :
>> "iomem",
>> +			(unsigned long long) start, (unsigned long
>> long) end);
>> +	}
>>  }
>>  
>>  static void reserve_resources_of_dev(struct pnp_dev *dev)
> 
> I'm inclined to keep the message, since it's just a dev_info and does
> provide interesting info sometimes.  So unless Linus wants to kill
> it...
> 
> Jesse
> 

This patch doesn't remove the message, it just removes the 'could not reserve' messages,
which would be useful if they are actual errors, but they are not. It's pretty silly if
the left hand doesn't know what the right is doing... However in the interest of keeping
the code as is, I guess the patch isn't all that important.

Regards,
David.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/